Fix #253 Add licenseMergesUrl also in report goals #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elballa
force-pushed
the
feature/253
branch
2 times, most recently
from
b7439a9
to
652cb45
Compare
|
There is still something missing in fix #253. It should be included in next release because licenseMergeUrl in not reliable if there is more then one raw in content of file linked by |
ppalaga
requested changes
Feb 25, 2019
src/main/java/org/codehaus/mojo/license/AbstractThirdPartyReportMojo.java
Outdated
Show resolved
Hide resolved
… in all report goals licenseMergeUrl parameter produces unreliable result in report goals if there is more then one raw in the content of linked file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still something missing in this fix #253. It should be included in next release because licenseMergeUrl in not reliable if there is more then one raw in content of file linked by licenseMergeUrl