Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 610 update-parent: add a possibility to skip version resolution and enforce a parent version #689

Conversation

jarmoniuk
Copy link
Contributor

@jarmoniuk jarmoniuk commented Sep 14, 2022

As explained in #610

If parentVersion is set, skipResolution will cause the mojo to completely skip version resolution and will simply set the parent version to the given version.

Added tests + enhanced the documentation.

@jarmoniuk jarmoniuk force-pushed the issue-610-update-parent-downgrade-to-ver branch from 4de9c46 to cd94167 Compare September 14, 2022 14:43
@jarmoniuk jarmoniuk marked this pull request as ready for review September 14, 2022 14:59
@jarmoniuk
Copy link
Contributor Author

@slachiewicz @slawekjaranowski please review

@jarmoniuk jarmoniuk force-pushed the issue-610-update-parent-downgrade-to-ver branch from cd94167 to dce0651 Compare September 16, 2022 04:55
@jarmoniuk
Copy link
Contributor Author

Could you please rerun failed jobs? Looks like it's infra.

@jarmoniuk
Copy link
Contributor Author

jarmoniuk commented Sep 16, 2022

I don't get it. I think the infra is not well today :)
Please restart again.

@slachiewicz
Copy link
Member

ok, now all green.

@slawekjaranowski slawekjaranowski linked an issue Sep 16, 2022 that may be closed by this pull request
@slawekjaranowski slawekjaranowski merged commit cb7ef70 into mojohaus:master Sep 16, 2022
@slawekjaranowski slawekjaranowski added this to the 2.13.0 milestone Sep 16, 2022
@jarmoniuk jarmoniuk deleted the issue-610-update-parent-downgrade-to-ver branch September 16, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting a project's parent version to a dedicated one
3 participants