Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #265: revert mojo to scan child modules instead of relying on maven #719

Merged
merged 1 commit into from Sep 29, 2022
Merged

Issue #265: revert mojo to scan child modules instead of relying on maven #719

merged 1 commit into from Sep 29, 2022

Conversation

jarmoniuk
Copy link
Contributor

@jarmoniuk jarmoniuk commented Sep 22, 2022 •
edited

Using PomHelper::getAllChildModules to retrieve all modules in the reactor to get files to revert. Relying on maven to process all enabled profiles did not revert all files changed by SetMojo, because SetMojo also uses getAllChildModules.

@jarmoniuk jarmoniuk changed the title Issue 265: revert mojo to scan child modules instead of relying on default maven behaviour Issue 265: revert mojo to scan child modules instead of relying on maven Sep 22, 2022
@jarmoniuk jarmoniuk force-pushed the issue-265-revert branch 3 times, most recently from 9c13825 to 473bff4 Compare September 22, 2022 08:02
@jarmoniuk
Copy link
Contributor Author

@slachiewicz @slawekjaranowski please review and merge

@slawekjaranowski slawekjaranowski linked an issue Sep 29, 2022 that may be closed by this pull request
Different profile used for versions:set and versions:revert . #265
Closed
@slawekjaranowski slawekjaranowski added this to the 2.13.0 milestone Sep 29, 2022
@slawekjaranowski slawekjaranowski changed the title Issue 265: revert mojo to scan child modules instead of relying on maven Issue #265: revert mojo to scan child modules instead of relying on maven Sep 29, 2022
@slawekjaranowski slawekjaranowski merged commit e7aa406 into mojohaus:master Sep 29, 2022
@jarmoniuk jarmoniuk deleted the issue-265-revert branch September 29, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski left review comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

Different profile used for versions:set and versions:revert .
2 participants
@jarmoniuk @slawekjaranowski