Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #340. #396

Closed
wants to merge 1 commit into from
Closed

Fix for #340. #396

wants to merge 1 commit into from

Conversation

Zegveld
Copy link
Contributor

@Zegveld Zegveld commented May 14, 2020

#340 issue in short: property versions are overwritten with actual versions instead of leaving them alone.

Also ran into this problem, fixed it by adding an ignore for versions that start with the '${' property reference announcer.

Added it everywhere I also saw the following bit of code that skipped the reactor dependencies:

            if ( isExcludeReactor() && isProducedByReactor( dep ) )
            {
                getLog().info( "Ignoring reactor dependency: " + toString( dep ) );
                continue;
            }

see also #340

@khmarbaise
Copy link
Member

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use-latest-versions ignores dependencies with versions defined as properties
2 participants