Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename in version.xml not correct #6

Closed
jurgweilenmannbradyplc opened this issue Aug 21, 2015 · 7 comments
Closed

Filename in version.xml not correct #6

jurgweilenmannbradyplc opened this issue Aug 21, 2015 · 7 comments
Assignees
Labels
Milestone

Comments

@jurgweilenmannbradyplc
Copy link

If you have a SNAPSHOT dependency, the filename in the war and the filename in version.xml does not match. As a result, WebStart can not download the file.

Example:
We have a dependency to jar sstl-util 1.11.0-SNAPSHOT

Filename in war/webstart: sstl-util-1.11.0-20150818.085702-5.jar

In version.xml:

  <resource>
    <pattern>
      <name>sstl-util.jar</name>
      <version-id>1.11.0-20150818.085702-5-20150821094500</version-id>
    </pattern>
    <file>sstl-util-1.11.0-SNAPSHOT.jar</file>
  </resource>

Should be:

  <resource>
    <pattern>
      <name>sstl-util.jar</name>
      <version-id>1.11.0-20150818.085702-5-20150821094500</version-id>
    </pattern>
    <file>sstl-util-1.11.0-20150818.085702-5.jar</file>
  </resource>

This has worked correctly in 1.0-beta-4, but does not work since 1.0-beta-5

@jerdehaas
Copy link

Running into a same issue:

At deploy phase in Jenkins suddenly the version.xml is changed to include a full version of the maven jar resource artifact while still refering to the short version. This does not happen when i build it with maven2/3 locally. Tried many version of maven all the same.

On Jenkins:
mvn clean install -> all ok
mvn deploy -> suddenly version.xml is changed to:

<resource> <pattern> <name>client-0.0.2-20150914.083802-20.jar</name> <version-id>0.0.2-20150914.083802-20</version-id> </pattern> <file>client-0.0.2-SNAPSHOT.jar</file> </resource>

Beta5 doesnt set the version of the library artifact to client-0.0.2-20150914.083802-20.jar but client-0.0.2-SNAPSHOT.jar, but version xml is still not good:

<resource> <pattern> <name> nl.prorail.argus-client-0.0.2-20150914.083802-20.jar </name> <version-id>0.0.2-20150914.083802-20</version-id> </pattern> <file>client-0.0.2-SNAPSHOT.jar</file> </resource>

As we require java8 its not possible to use beta4, vote for quick fix.

@mkotiaho
Copy link

I have this problem also.
Actual filename: swt-win32-3.5.57.jar
In version.xml: swt-3.5.57-win32.jar

This worked correctly in 1.0-beta-4, not sure about 1.0-beta-5.

@tchemit tchemit added this to the 1.0-beta-8 milestone Feb 26, 2016
@tchemit tchemit self-assigned this Feb 26, 2016
@tchemit tchemit added the bug label Feb 26, 2016
@jonfreedman
Copy link

I just confirmed that 1.0-beta-7 still has this issue (& looks like that's expected based on the updates to this ticket last week). It would be great to get a fix as currently it's not possible to launch a snapshot jnlp after it's deployed via Nexus.

@tchemit
Copy link
Contributor

tchemit commented Mar 4, 2016

I will have a look this week-end or next week.

crussellgh pushed a commit to crussellgh/webstart that referenced this issue Jun 24, 2016
@rdp
Copy link

rdp commented Jul 15, 2016

Yes, same failure here, worked fine with 1.0-beta-2, thanks

@tchemit
Copy link
Contributor

tchemit commented Oct 23, 2016

I just create the MR for this (See #42)

@tchemit tchemit closed this as completed Oct 23, 2016
tchemit added a commit that referenced this issue Oct 23, 2016
Fix Filename in version.xml file for snapshot (See #6)
@rdp
Copy link

rdp commented Oct 22, 2018

I could really use a new version released that has this fix in it, FWIW...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants