Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ValidationSet documentation around well-formedness vs validation #47

Closed
rosslamont opened this issue Apr 17, 2018 · 0 comments
Closed

Improve ValidationSet documentation around well-formedness vs validation #47

rosslamont opened this issue Apr 17, 2018 · 0 comments
Assignees
@rosslamont
Labels
enhancement
Milestone
Release 1.0.3

Comments

@rosslamont
Copy link
Contributor

Technically 2 issues

  • How publicId, systemId and validating work together to decide whether or not the document should be validated could be simplified.
  • descriptions for includes and excludes is incorrect, as actually the includes and excludes approach used is the standard maven plugin approach with nested include or exclude elements. As some other plugins use non-standard approaches this could cause confusion.
@rosslamont rosslamont added this to the Release 1.0.3 milestone Apr 17, 2018
@rosslamont rosslamont self-assigned this Apr 17, 2018
@rosslamont rosslamont mentioned this issue Apr 17, 2018
Closed
@rosslamont rosslamont mentioned this issue May 1, 2018
Open
rosslamont added a commit that referenced this issue May 4, 2018
@rosslamont
Merge pull request #49 from rosslamont/issue-47
161edde 
fixed #47.

 - Added some test cases around well-formedness checking.  Motivation was 
to better understand and document well-formedness checking.
 - Significant improvements in documentation, including clarification of
includes and excludes elements, validation configuration, particularly
around well-formedness and the "validating" flag.  
 - Enhancement of documentation formatting to improve clarity
 - Some additional hyperlinking from generated documents (mojo report)
to expose the more detailed documentation available from the usage page.
@1stone 1stone mentioned this issue Oct 5, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosslamont rosslamont

Labels
enhancement
Projects
None yet
Milestone
Release 1.0.3
Development

No branches or pull requests
1 participant
@rosslamont