Fixed #26. (Report on multiple validation errors) #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Validator.validate, most validation errors will be ignored. The only reliable way to capture validation errors is to use an error handler, as Validator.validate only throws fatal errors (validation errors are not fatal - see javadoc for ErrorHandler) Solution applied refactors existing error handling approach to always use an ErrorHandler to capture errors. As a bonus, you should get log messages showing multiple failures, rather than just the first.
rosslamont
changed the title
rosslamont
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Improve usability by detecting multiple validation errors in one pass
Solution: Use a custom ErrorHandler to collect all errors and report them after validation. Existing error formatting code has been moved untouched to a new method.