Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #28 (support jdk6 on travis trusty builds) #29

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

rosslamont
Copy link
Contributor

@rosslamont rosslamont commented Sep 21, 2017

Motivation: openjdk6 builds no longer work because openjdk6 is not available on travis trusty environments and maven version seems to have been upgraded past 3.3.0 (which was built on jdk7)

Fix:

  • use apt to fetch openjdk 6
  • use script to fetch specific versions of maven for different idk environments

- jdk: oraclejdk8
env: CUSTOM_MVN_VERION="3.5.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there really a relationship between Maven version and JDK 8 in particular Maven 3.5.0 has a minimum of JDK 7 to run...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, and I'm sorry I forgot to document my trail. Short answer: no idea - I copied what worked for another project.

I am not 100% certain, but I'm pretty sure this was the reference I used. The maven version for JDK6 was the only one I checked - I believe that is the last version supporting jdk6. The others were simply copied across on the basis of going with something that works, and my lack of familiarity with travis scripting. It may make sense to use some other version.

In any case, this particularly plugin is unlikely to have a strong need for any particular version of maven.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another solution might be to abandon jdk6 entirely, or compile with JDK7 or 8 with jdk6 compatibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other thing as background. At first I tried simply installing openjdk6, but that failed to execute maven due to an UnsupportedClassVersionError when running maven, so definitely maven had to be downgraded for JDK6. Now I think about it you could probably delete the env: for JDK7 and JDK8. Shall I give that a shot?

@jochenw jochenw merged commit 16cfaf0 into mojohaus:master Sep 25, 2017
@rosslamont rosslamont deleted the issue-28 branch October 3, 2017 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants