Fixed #34. Handle relative href in xml-model processing instructions #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closing: wrong solution - this solution interferes with the "basedir" mojo parameter. Probably a better solution for v2.0 |
do not work. As this is relying on the EntityResolver, there are possibly other relative entity resolutions which do not work either. Solution: Added relative URI handling to the resolveURL method of Resolver class. Code attempts the original code path before attempting to resolve relative URI's to preserver legacy behavior as much as possible. - also updated latest jxvc version.
|
Upon further thought, it was possible to keep the original resolution approach which first tries to resolve as a URI, and then attempts to use basedir. If the original approach fails, and the URI is relative, then the new approach is used. |
rosslamont
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: When resolving xml-model style validations, relative href
do not work. As this is relying on the EntityResolver, there are possibly
other relative entity resolutions which do not work either.
Solution: Added relative URI handling to the resolveURL method of Resolver
class. Code attempts the original code path before attempting to resolve
relative URI's to preserver legacy behavior as much as possible.
Fixed #34