Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[site/examples] Typos in XSD schema validation #52

Closed

Conversation

whatthefrog
Copy link

feels less confusing to have the <dir> being /xml, and the xmlschema file with a xsd extension

feels less confusing to have the `<dir>` being `/xml`, and the `xmlschema` file with a `xsd` extension
@jochenw
Copy link
Member

jochenw commented Jul 8, 2019

Rejected. Doesn't a) fix a bug, or b) add new functionality, but forsakes upwards compatibility.

@jochenw jochenw closed this Jul 8, 2019
@whatthefrog
Copy link
Author

I am sorry if you do not see this change as an improvement...

Documentation is "code for humans", so typos in it made me lost some of my time, trying to understand where should the XML files to validate be, and where to put the XSD schema ...

Moreover, on line 27, you mention <<<src/main/xmlschema.xsd>>> (xsd extenstion), and then in the snippet, line 47 <systemId>src/main/xmlschema.xml</systemId> (xml extension)

So I then invested a bit of my time to give back to the community, so others do not fall in the same trap...

Not sure I do understand you, just took more time to explain why you rejected, rather than clicking "merge".

Thanks for the plugin, it works and suits my present needs,
Thanks for the time it took you to write it

@jochenw
Copy link
Member

jochenw commented Jul 9, 2019

Okay, but your PR would change more than that typo. What I particularly don't want is the change of the default directory, which would break all builds, that depend on that default. We simply don't do that.

@whatthefrog
Copy link
Author

I thought that the src/site/apt/examples/validate-schema.apt file is what is used to generate the documentation that is hosted http://www.mojohaus.org/xml-maven-plugin/examples/validate-schema.html ... but seems that I misunderstood something

@jochenw
Copy link
Member

jochenw commented Jul 9, 2019

YXou got me, I misunderstood. Sorry for that. Reopening.

@jochenw jochenw reopened this Jul 9, 2019
Copy link
Member

@jochenw jochenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About time to pull this in. Sorry for the delay!

@jochenw jochenw closed this in baeff56 Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants