Subselects for queries that modify the selected row need to use FOR U…

…PDATE (closes #90)
mojolicious · Dec 16, 2019 · a9a00ff · a9a00ff
1 parent 17868bd
commit a9a00ff
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,6 @@
 
-10.01  2019-11-16
+10.01  2019-12-16
+  - Fixed an unlock concurrency issue in Minion::Backend::Pg.
 
 10.0  2019-11-15
   - Removed PostgreSQL migrations older than 2 years, that means you need to

diff --git a/lib/Minion/Backend/Pg.pm b/lib/Minion/Backend/Pg.pm
@@ -271,7 +271,7 @@ sub unlock {
   !!shift->pg->db->query(
     'delete from minion_locks where id = (
        select id from minion_locks
-       where expires > now() and name = ? order by expires limit 1
+       where expires > now() and name = ? order by expires limit 1 for update
      ) returning 1', shift
   )->rows;
 }