Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to popper.js #115

Merged
merged 1 commit into from Oct 8, 2021
Merged

Remove references to popper.js #115

merged 1 commit into from Oct 8, 2021

Conversation

kiwiroy
Copy link
Contributor

@kiwiroy kiwiroy commented Oct 7, 2021

Summary

Remove references to popper.js

Motivation

Remove unused code that refers to files no longer distributed in Minion.

References

#114

christopherraa
christopherraa approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@christopherraa christopherraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

jhthorsen
jhthorsen approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@jhthorsen jhthorsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on @kraih’s feedback I would say this change does it

@kiwiroy kiwiroy mentioned this pull request Oct 8, 2021
Merged
@mergify mergify bot merged commit 53f6e43 into mojolicious:main Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraih kraih kraih approved these changes

@jhthorsen jhthorsen jhthorsen approved these changes

@christopherraa christopherraa christopherraa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kiwiroy @kraih @jhthorsen @christopherraa