Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to include @import files in sass when calculating checksum #25

Closed
jhthorsen opened this issue Aug 28, 2014 · 5 comments
Closed

Need to include @import files in sass when calculating checksum #25

jhthorsen opened this issue Aug 28, 2014 · 5 comments
Assignees

Comments

@jhthorsen
Copy link
Member

Often there's one top level file which include a bunch of @import "foo.scss"; statements. This means that the file that AssetPack use to calculate the checksum is very static, while all the @import files change.

Would be nice if AssetPack could (at least) calculate checksum from the first level of @import statements.

@jhthorsen jhthorsen self-assigned this Aug 28, 2014
@marcusramberg
Copy link
Member

I guess it's a challenge to parse sass files correctly without a sass parser. These things could technically go across multiple lines and such too, right?

@jhthorsen
Copy link
Member Author

Could be. I was thinking something like this 144a8b6#diff-0d0ee58f73977849f0c599ada76f0ae7R34

@marcusramberg
Copy link
Member

Well, it'll work for the most common cases at least.

@jhthorsen
Copy link
Member Author

Don't say "most common cases" without telling what's missing.

@jhthorsen
Copy link
Member Author

Other cases:

@import "rounded-corners", "text-shadow";
$family: unquote("Droid+Sans");
@import url("http://fonts.googleapis.com/css?family=#{$family}");

Think I'm skipping the whole url() syntax, and probably variables as well.

jhthorsen pushed a commit that referenced this issue Sep 7, 2014
jhthorsen pushed a commit that referenced this issue Sep 7, 2014
       * Add AssetPack->fetch() method #24
       * Can calculate checksum with included .sass and .scss files #25
       * Can load external assets with minify=0 #27
       * Support printing sass error to web page #26
       * Better error message when unable to find asset file
       * Change to using objects for processing files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants