-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in Docs #53
Comments
It seems like there original documentations included "only" in the three instances of this construction. It was changed in each case in this commit: cd07e1e |
Hi Joel
Thanx for the follow-up. But that means there are yet more grammatical
problems :-(.
…On 15/1/19 4:58 am, Joel Berger wrote:
It seems like there original documentations included "only" in the three
instances of this construction. It was changed in each case in this
commit: cd07e1e
<cd07e1e>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ai1WBrv7BrbdsyG4qprtmJTk0aJYkXarks5vDMU9gaJpZM4Z9dbw>.
--
Ron Savage - savage.net.au
|
Based on that commit, I think the easiest correction is to add a comma after 'So far,' in each case. The 'are supported' at the end of the sentence is important to understanding it currently, a comma would make it easier to read. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce the behavior
In the docs for SQL::Abstract::Pg, under ON CONFLICT, the sentence 'So far undef to pass DO NOTHING, ...' is hard to understand due to the use of 'far'. Did you mean 'use'?
Expected behavior
EXPLAIN WHAT SHOULD HAPPEN HERE
Actual behavior
EXPLAIN WHAT HAPPENED INSTEAD HERE
The text was updated successfully, but these errors were encountered: