Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Docs #53

Closed
ghost opened this issue Jan 14, 2019 · 3 comments
Closed

Typo in Docs #53

ghost opened this issue Jan 14, 2019 · 3 comments

Comments

@ghost
Copy link

ghost commented Jan 14, 2019

  • Mojo::Pg version: 4.12
  • Perl version: 5.20.2
  • Operating system: Debian 8.11

Steps to reproduce the behavior

In the docs for SQL::Abstract::Pg, under ON CONFLICT, the sentence 'So far undef to pass DO NOTHING, ...' is hard to understand due to the use of 'far'. Did you mean 'use'?

Expected behavior

EXPLAIN WHAT SHOULD HAPPEN HERE

Actual behavior

EXPLAIN WHAT HAPPENED INSTEAD HERE

@jberger
Copy link
Member

jberger commented Jan 14, 2019

It seems like there original documentations included "only" in the three instances of this construction. It was changed in each case in this commit: cd07e1e

@ghost
Copy link
Author

ghost commented Jan 14, 2019 via email

@Grinnz
Copy link
Contributor

Grinnz commented Jan 14, 2019

Based on that commit, I think the easiest correction is to add a comma after 'So far,' in each case. The 'are supported' at the end of the sentence is important to understanding it currently, a comma would make it easier to read.

@kraih kraih closed this as completed in 581995c Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants