Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Mojo::IOLoop::one_tick die on recursion #1015

Closed
kraih opened this issue Nov 7, 2016 · 0 comments
Closed

Make Mojo::IOLoop::one_tick die on recursion #1015

kraih opened this issue Nov 7, 2016 · 0 comments

Comments

@kraih
Copy link
Member

kraih commented Nov 7, 2016

Recently i've seen more and more applications abuse Mojo::IOLoop::one_tick to recurse back into the event loop and emulate blocking behaviour while waiting for events. This does of course not really work as soon as there is any real load on the server and will make applications crash in very unexpected ways.

Therefore i believe we should just not allow Mojo::Reactor::Poll::one_tick and Mojo::Reactor::EV::one_tick to recurse, and instead die right away if it is ever attempted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant