Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Die in JSONConfig->parse not reported #318

Closed
jploski opened this issue Apr 14, 2012 · 3 comments
Closed

Die in JSONConfig->parse not reported #318

jploski opened this issue Apr 14, 2012 · 3 comments

Comments

@jploski
Copy link

jploski commented Apr 14, 2012

Reporting against kraih-mojo-b183a2e:

When Mojolicious::Plugin::JSONConfig::parse dies, only a nonsensical error message is displayed by morbo:

Can't load application "script/boilerplate.pl": at (eval 105) line 5.

(The actual scenario which led me to discover this was an attempt to use Mojolicious::Plugin::YamlConfig without YAML::XS installed, but hopefully you can simply reproduce this by inserting die anywhere in Mojolicious::Plugin::JSONConfig::parse - this has the same effect for me.)

@kraih kraih closed this as completed in 62ec604 Apr 14, 2012
@jploski
Copy link
Author

jploski commented Apr 14, 2012

I can't quite understand the patch. Were you able to identify the root cause or was my report invalid? Because JSONConfig now outputs the error message correctly in my tests, but the original problem with YamlConfig remains. It seems to be caused by "local $@;" in YamlConfig::parse, and it also depends on whether I run with morbo (error message is suppressed) or in daemon mode (error message appears).

@kraih
Copy link
Member

kraih commented Apr 14, 2012

YamlConfig is not a core plugin, i'm afraid you will have to contact its author.

@jploski
Copy link
Author

jploski commented Apr 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants