Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mojo::Log: log->level ignored in favor of MOJO_LOG_LEVEL #475

Closed
powerman opened this issue Apr 9, 2013 · 1 comment
Closed

Mojo::Log: log->level ignored in favor of MOJO_LOG_LEVEL #475

powerman opened this issue Apr 9, 2013 · 1 comment

Comments

@powerman
Copy link

powerman commented Apr 9, 2013

Doc says "defaults to the value of the MOJO_LOG_LEVEL" at
https://github.com/kraih/mojo/blob/master/lib/Mojo/Log.pm#L134

But implementation completely ignore log->level when MOJO_LOG_LEVEL set:
https://github.com/kraih/mojo/blob/master/lib/Mojo/Log.pm#L50

If this is intentional behavior then doc should be improved, because now it sounds like MOJO_LOG_LEVEL used to provide initial value for log->level instead of "debug".
If not - then it's a bug.

Also, when MOJO_LOG_LEVEL is set log->level return wrong value ("debug").

@kraih kraih closed this as completed in 67523ed Apr 9, 2013
@kraih
Copy link
Member

kraih commented Apr 9, 2013

Thanks, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants