Problem when dealing with "Content-Disposition" header at Mojo::Message?

[s-murata]

If a backslash(\) exists at the end point of a uploaded file name, a parsed file name is include a double quote(").
I seem a problem exists in in Mojo::Message::parse_formdata method.

    my ($filename) = $disposition =~ /[; ]filename\s*=\s*"?((?:\\"|[^"])*)"?/i;

For example, when the file name is foo\"bar\, and Content-Disposition header includes ; filename="foo\"bar\", that regular expression matches foo\"bar\".
A $name variable has a same problem too.

    my ($name) = $disposition =~ /[; ]name\s*=\s*"?((?:\\"|[^";])+)"?/i;

My proposal is ...

    my ($filename) = $disposition =~ /[; ]filename\s*=\s*"?((?:\\"(?!\s|\z)|[^"])*)"?/i;

and

    my ($name) = $disposition =~ /[; ]name\s*=\s*"?((?:\\"(?!;|\s|\z)|[^";])+)"?/i;

Any good idea?

[kraih]

Your proposed change breaks existing tests.

[s-murata]

Sorry, exactly. Break if file name include white spaces.

I'll think alternative.

[kraih]

Thanks, fixed.

[s-murata]

Thanks for your commit.
I was a bit late:)

    (undef, my $filename) = $disposition =~ /[; ]filename\s*=\s*("?)((?:\\"|[^"])*)\1/i;

Your commit is better and more simple. Thanks.