Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

again Mojo::Reactor::EV #767

Closed
bakanov opened this issue Mar 20, 2015 · 4 comments
Closed

again Mojo::Reactor::EV #767

bakanov opened this issue Mar 20, 2015 · 4 comments

Comments

@bakanov
Copy link

bakanov commented Mar 20, 2015

When I try perform 'again' with Mojo::Reactor::EV backend and timer that not exist it cause server error:
[Fri Mar 20 10:35:06 2015] [error] Can't call method "again" on an undefined value at /usr/local/share/perl/5.14.2/Mojo/Reactor/EV.pm line 12.
If I do the same with Poll backend it causes only warning.
I think usage of wrong timer value shouldn't cause server error. Or there should be method to check if timer exists

@kraih
Copy link
Member

kraih commented Mar 20, 2015

I think this feature request needs an actual use case, so far it sounds to me like it would only hide timing bugs.

@kraih
Copy link
Member

kraih commented Mar 20, 2015

Something like this would seem reasonable, since it could be used for testing as well, but we still need a good use case.

@kraih kraih closed this as completed in c19f663 Mar 20, 2015
@kraih
Copy link
Member

kraih commented Mar 20, 2015

Since no use case has been presented, i've decided to go the opposite direction and make both reactors fail consistently. Hopefully this can prevent a few bugs in the future.

@bakanov
Copy link
Author

bakanov commented Mar 21, 2015

OK, it's reasonable, thanks.

P.S. Sorry for late answer. Actually, this issue was connected to this thread: https://groups.google.com/forum/#!topic/mojolicious/tWZmcc-mfoM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants