Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change liquid converter order #895

Closed

Conversation

jyruzicka
Copy link

  • Liquid tags are now parsed after converters are run on files.
  • Liquid tags are encoded as HTML comments (sample: <!--LIQUID-a4ef62-2-->) during conversion, using the new LiquidEncoder class.
  • {% include %} liquid tag will now run included files through converters if any match their extension
  • Docs have been updated to explicitly mention order of parsing for files with YAML front-matter, and to mention that included files are converted if their extension matches.

@mattr-
Copy link
Member

mattr- commented Mar 29, 2013

568900c, a3826dd, and 73bdd7b all have commit messages that are too long. Please see http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html for how to write proper git commit messages.

@jyruzicka
Copy link
Author

@mattr Cheers for the feedback - first time contributing to someone else's repo rather than just keeping my own in check, so expect some newb mistakes.

What's the preferred method of fixing git commit messages?

@mattr-
Copy link
Member

mattr- commented Mar 29, 2013

I'm actually not sure. I've never had to do that before.

@ixti
Copy link
Member

ixti commented Mar 29, 2013

You can't change commit messages on remote. Instead you can git rebase -i
on local branch and open a new pull request. See:

@mattr https://github.com/mattr Cheers for the feedback - first time
contributing to someone else's repo rather than just keeping my own in
check, so expect some newb mistakes.

What's the preferred method of fixing git commit messages?


Reply to this email directly or view it on GitHubhttps://github.com//pull/895#issuecomment-15628074
.

@jyruzicka
Copy link
Author

@ixti Thanks! git rebase navigated, I'll re-submit the pull request.

@jyruzicka jyruzicka closed this Mar 29, 2013
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants