-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comparing semver to non-semver #368
Comments
Yes. Semver itself doesn't have anything g to say about this. |
SteveL-MSFT
added a commit
to SteveL-MSFT/PowerShell
that referenced
this issue
May 8, 2017
…fied which broke scenarios like: `$psversiontable.psversion -gt "3.0"` which is used by PowerShellGet to determine if a module is compatible with the current version of PowerShell. Change is to allow specifying only major or major+minor where the missing segments default to zero by providing overloaded constructors and allow the string parsing method to not require major, minor, and patch segments to all be specified (only major is required). Based on the [response](semver/semver#368) from the maintainer of semver, there is no requirement to have strict conformance for the inputs to the constructor and allowing "3.0" to result in a semver of 3.0.0 is reasonable.
lzybkr
pushed a commit
to PowerShell/PowerShell
that referenced
this issue
May 8, 2017
) `$psversiontable.psversion -gt "3.0"` which is used by PowerShellGet to determine if a module is compatible with the current version of PowerShell. Change is to allow specifying only major or major+minor where the missing segments default to zero by providing overloaded constructors and allow the string parsing method to not require major, minor, and patch segments to all be specified (only major is required). Based on the [response](semver/semver#368) from the maintainer of semver, there is no requirement to have strict conformance for the inputs to the constructor and allowing "3.0" to result in a semver of 3.0.0 is reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We've converted to using semver in http://github.com/powershell/powershell, however, for compatibility reasons we have situations where we have to compare our semver against a non-conforming version. For example, check if 6.0.0 is greater than 3.0 as older tools built on older versions of PowerShell only expect major.minor. To do this comarison, we would like to convert 3.0 to 3.0.0 where we assume the patch version is 0. Is this acceptable from a semver standpoint where we moved from major.minor to semver?
The text was updated successfully, but these errors were encountered: