allow phoenix 1.5

[agramichael]

No description provided.

[cpjolicoeur]

@agramichael I'm assuming you've been able to run through and install/test torch on a 1.5 app? I haven't gotten around to testing this out yet, hope to this week or next.

If you've run through it, I'm happy to drop the 1.5 constraint for now as we can always add it back in if/when bugs with 1.5 arise, but I dont really anticipate any based on the 1.5 Changelog

[agramichael]

@cpjolicoeur I noticed 1 thing which was the torch.html.eex which was generated for my app was rendering in a way which is now deprecated.

I replaced
<%= render @view_module, @view_template, assigns %>
with
<%= @inner_content %>
and everything seems to work.

[agramichael]

Phoenix also requires you to specify the library to used for json encoding. I set it so Jason, which is recommended, but Poison can be used.

As a side note: in order to run tests within the Torch app, I had to upgrade telemetry and ecto_sql libraries.

[cpjolicoeur]

@agramichael Thanks. I've spun up a larger branch this morning to update the test suite a bit and run integration tests for phx 1.3, 1.4, and 1.5 independently.

When I have that ready I'll link to it here to have you take a look and then we can get full 1.5 support in including configs and generators in a new Torch release.

[cpjolicoeur]

@agramichael Can you take a peek at #152 and let me know what you think?

[agramichael]

@cpjolicoeur Looks perfect to me!! Thanks

[cpjolicoeur]

@agramichael Thanks for all the help on this. Torch v3.2.0 has been released to hex with these changes.