append the lists instead of string concatenation #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hanskenis Hey, sorry about the delayed response! For some reason I wasn't "watching" this repo. It seems like a reasonable solution. @danielberkompas will need to verify. |
|
Apparently good to go. :) |
|
@jamonholmgren: It's strange, because now i'm getting errors on the list appending. Maybe it's depending on another library that i upgraded, but now it seems like this should be as it was before. |
|
I looked a bit further and the fix is correct when Phoenix.Html is version 2.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #42