Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Makefile to solve hardening problems #2

Merged
merged 1 commit into from Mar 28, 2022
Merged

Fix Makefile to solve hardening problems #2

merged 1 commit into from Mar 28, 2022

Conversation

kretcheu
Copy link
Contributor

Include LDFLAGS and += to provide include values to CFLAGS

Please consider to merge this changes.
Thanks.

@kretcheu
Fix Makefile to solve hardening problems
b7f8cb8 
Include LDFLAGS and += to provide include values to CFLAGS
mojotx
mojotx approved these changes Mar 28, 2022
View reviewed changes
Copy link
Owner

@mojotx mojotx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am tentatively okay with these changes. I generally prefer to let the Makefile dictate the flags needed for building, but I can understand that sometimes there may be a need to use flags from the environment.

@mojotx mojotx merged commit 86d9b86 into mojotx:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mojotx mojotx mojotx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kretcheu @mojotx