Prevent future::get_or_*_insert_with to panic after inserting task was aborted
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sk was aborted Add unit tests.
…sk was aborted Add `WaiterGuard` to `future::value_initializer` which will ensure that the waiter will be removed when the enclosing future has been aborted. Fixes #59.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue described in #59. So
get_or_insert_withandget_or_try_insert_withmethods infuture::Cachewill no longer panic if previous inserting task was aborted.Changes
WaiterGuardto the value initializer used by these methods and it will ensure to remove the waiter (a lock) when enclosing async task is aborted.Fixes #59.