Import cht source files for better integration #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add source files (modules) used by Moka (as `moka::cht::*` modules). - Remove moka-cht crate from the dependency. - Add crossbeam-epoch v0.8.2 to the dependency. - Update the existing `use` statement in Moka modules to refer to `moka::cht::SegmentedHashMap`. - Temporary disable unit tests for `cht::*` modules.
- Change visibility of `moka::cht::*` modules from public to crate public. - Remove unused feature `num_cpu` from `moka::cht::*` modules.
- Remove `GlobalStats`, which was added by us (Moka authors) and used for performance testing.
- Move the Credit section in the README up above the License section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds source files imported from moka-cht crate.
Changes
moka::cht::*modules).usestatement in Moka modules to refer tomoka::cht::SegmentedHashMap.moka::cht::*modules from public to crate public.num_cpufrommoka::cht::*modules.cht::*modules.Remaining Action Items
moka::cht::*modules.