Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable cht tests #86

Merged
merged 4 commits into from
Feb 5, 2022
Merged

Enable cht tests #86

merged 4 commits into from
Feb 5, 2022

Conversation

tatsuya6502
Copy link
Member

Fixes #78.

@tatsuya6502 tatsuya6502 self-assigned this Feb 4, 2022
@tatsuya6502 tatsuya6502 added the enhancement New feature or request label Feb 4, 2022
@tatsuya6502 tatsuya6502 added this to the v0.7.2 milestone Feb 4, 2022
@tatsuya6502
Update and re-enable tests for SegmentedHashMap
7fbfa3e 
Ignore some tests to avoid error in QEMU user space emulator on 32-bit
MIPS and ARMv5te targets.
@tatsuya6502
Update and re-enable tests for SegmentedHashMap
0c27f4d 
Ignore some tests to avoid error in QEMU user space emulator on 32-bit
MIPS and ARMv5te targets.
@tatsuya6502
Copy link
Member Author

Due to runtime errors, I had to disable some tests around concurrent modifications on the following cross compiling targets:

  • 32-bit MIPS architecture:
    • Error: memory allocation of 1052 bytes failed. signal: 6, SIGABRT: process abort signal.
    • Targets:
      • mips-unknown-linux-musl — 8 tests disabled.
      • mipsel-unknown-linux-musl — 8 tests disabled.
  • 32-bit ARMv5 architecture:
    • Error: signal: 4, SIGILL: illegal instruction
    • Target: armv5te-unknown-linux-musleabi — 1 test disabled.

They might be caused by the incomplete supports on atomic operations in QEMU user space emulator:

https://www.qemu.org/docs/master/user/main.html

Note that not all targets currently emulate atomic operations correctly. x86 and Arm use a global lock in order to preserve their semantics.

@tatsuya6502 tatsuya6502 marked this pull request as ready for review February 5, 2022 07:37
tatsuya6502
tatsuya6502 commented Feb 5, 2022
View reviewed changes
Copy link
Member Author

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging.

@tatsuya6502 tatsuya6502 merged commit ecce22e into master Feb 5, 2022
@tatsuya6502 tatsuya6502 deleted the enable-cht-tests branch February 5, 2022 07:40
@tatsuya6502
Copy link
Member Author

Forgot to mention. I updated the expectations of drop tests to match the new behavior introduced by #79.

https://github.com/moka-rs/moka/pull/86/files#diff-3fa25a7df0be7616bdf3de6b4f851b5c531ffbb7f6415a913f2946d0e882d74aL726-R650

@tatsuya6502 tatsuya6502 mentioned this pull request Feb 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tatsuya6502 tatsuya6502

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.7.2
Development

Successfully merging this pull request may close these issues.

Enable unit tests for moka::cht::* modules
1 participant
@tatsuya6502