Fix security vulnerabilities #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icebob That @hapi/accept is a high vulnerability and its for DoS so it would probably be good to get another release out to address it. Bad timing with a release being shipped today... |
icebob
approved these changes
Mar 4, 2020
|
Released 0.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing the latest release I saw that there was a security vulnerability in
@hapi/acceptand they have deprecated the 4.x.x version. Unfortunately that advisory came out the day after this repo was updated to 4.x.x. It looks like they now show 3.2.4 as fixed and supporting node 10 which previously only indicated node 8. I have downgraded the version to 3.2.4 to avoid the security vulnerability.Additionally, there was a vulnerability coming from npm-check. I figured that while I was fixing one vulnerability I would take care of the other.