asserting dead-letter exchange and queue #68
Conversation
There was a problem hiding this comment.
Hi @ujwal-setlur Thank you for the PR. I've checked and left some comments
Can you please add a test for this? It's only necessary for the AMQP (other adapters create queues automatically)
src/adapters/amqp.js
Outdated
|
|
||
| // assert dead letter queue | ||
| this.logger.debug(`Asserting queue '${chan.deadLettering.queueName}'`); | ||
| await this.channel.assertQueue(chan.deadLettering.queueName, queueOptions); |
There was a problem hiding this comment.
Same as above
await this.channel.assertQueue(chan.deadLettering.queueName, _.defaultsDeep(
{},
chan.deadLettering ? chan.deadLettering.queueOptions : {},
this.opts.queueOptions
));
``
src/adapters/amqp.js
Outdated
| @@ -434,22 +468,10 @@ class AmqpAdapter extends BaseAdapter { | |||
| * @param {Object} msg | |||
| */ | |||
| async moveToDeadLetter(chan, msg) { | |||
There was a problem hiding this comment.
All the adapters have the HEADER_ORIGINAL_CHANNEL and HEADER_ORIGINAL_GROUP in headers. Removing this logic is something that we would like to avoid in here.
Can you please revert to the original logic?
There was a problem hiding this comment.
@AndreMaz, OK. The reason I did that is that at high message rates, the republish can get a buffer full, and it will throw an error then which then terminates the process. That's not good. At best, it should throw away the message. I will change it to that. Let me know if that's OK.
|
@AndreMaz Thanks for the comments. I will review. |
|
@AndreMaz I have addressed comments. I will add a test as well. |
This is a PR to assert the dead-letter exchange and queue in the amp adapter, to address #67
The PR asserts the exchange and queue during subscription of the first channel. This was tested by throwing an exception in the channel handler and checking the dead-letter queue on RabbitMQ.