Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for qs options #326

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

daniel-parakey
Copy link
Contributor

@daniel-parakey daniel-parakey commented Jun 27, 2023

Closes #309

Copy link
Member

@intech intech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-parakey
Copy link
Contributor Author

Made a mistake where I put the parameter inside the routes object in index.d.ts. Force-pushed a new version

@daniel-parakey
Copy link
Contributor Author

@icebob do you have an ETA of when this might be approved/merged? We're using my fork for the time being, but having this in master would be nice.

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Could you help to mention this new options in the docs as well?

@icebob icebob merged commit 9985806 into moleculerjs:master Jul 11, 2023
5 checks passed
@icebob
Copy link
Member

icebob commented Jul 11, 2023

@icebob do you have an ETA of when this might be approved/merged? We're using my fork for the time being, but having this in master would be nice.

I plan to release it at the weekend.

@daniel-parakey
Copy link
Contributor Author

@icebob nice, thanks! Docs change can be found here: moleculerjs/site#202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for array query strings
3 participants