Merge pull request #1221 from MichaelErmer/patch-1

Fix: prometheus reporter to accept host option

src/metrics/reporters/prometheus.js

@@ -54,6 +54,14 @@ class PrometheusReporter extends BaseReporter {
 				nodeID: registry.broker.nodeID
 			})
 		});
+
+		if (!this.opts.host && this.opts.port !== 0) {
+			this.opts.host = "0.0.0.0";
+		}
+		if (this.opts.port === 0) {
+			// host can not be used in combination with port 0 = auto port assignment
+			delete this.opts.host;
+		}
 	}
 
 	/**
@@ -66,7 +74,7 @@ class PrometheusReporter extends BaseReporter {
 
 		this.server = http.createServer();
 		this.server.on("request", this.handler.bind(this));
-		this.server.listen(this.opts.port, err => {
+		this.server.listen(this.opts.port, this.opts.host, err => {
 			if (err) {
 				/* istanbul ignore next */
 				return this.registry.broker.fatal(
@@ -75,7 +83,9 @@ class PrometheusReporter extends BaseReporter {
 			}
 
 			this.logger.info(
-				`Prometheus metric reporter listening on http://0.0.0.0:${this.opts.port}${this.opts.path} address.`
+				`Prometheus metric reporter listening on http://${this.server.address().address}:${
+					this.server.address().port
+				}${this.opts.path} address.`
 			);
 		});
 		this.defaultLabels = isFunction(this.opts.defaultLabels)

test/unit/metrics/reporters/prometheus.spec.js

@@ -24,6 +24,7 @@ describe("Test Prometheus Reporter class", () => {
 				metricNameFormatter: null,
 				labelNameFormatter: null,
 
+				host: "0.0.0.0",
 				port: 3030,
 				path: "/metrics",
 				defaultLabels: expect.any(Function)
@@ -39,6 +40,7 @@ describe("Test Prometheus Reporter class", () => {
 				metricNameFormatter: () => {},
 				labelNameFormatter: () => {},
 
+				host: "0.0.0.0",
 				port: 12345,
 				path: "/meter"
 			});
@@ -51,6 +53,7 @@ describe("Test Prometheus Reporter class", () => {
 				metricNameFormatter: expect.any(Function),
 				labelNameFormatter: expect.any(Function),
 
+				host: "0.0.0.0",
 				port: 12345,
 				path: "/meter",
 				defaultLabels: expect.any(Function)