Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autodetect Redis type discoverer when using redis SSL URI #1260

Conversation

Freezystem
Copy link
Contributor

📝 Description

I've encountered an error when I tried to use an SSL redis URI.
To fix this issue, I've just add another case for the match of a redis URI: rediss://.

🎯 Relevant issues

#1259

💎 Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

📜 Example code

const broker = new ServiceBroker({
    discoverer: "rediss://redis-server:6379"
});

🚦 How Has This Been Tested?

  • Check that uri starting with rediss:// are identified as Redis type discoverer

🏁 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Freezystem Freezystem force-pushed the fix.discoverer-rediss-uri-not-detected-as-redis branch from 8291026 to 2b1116f Compare November 21, 2023 23:42
@Freezystem Freezystem force-pushed the fix.discoverer-rediss-uri-not-detected-as-redis branch from aac5b01 to d249c27 Compare November 21, 2023 23:58
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@icebob icebob linked an issue Nov 26, 2023 that may be closed by this pull request
4 tasks
@icebob icebob merged commit 3889543 into moleculerjs:master Nov 26, 2023
177 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis SSL URI not reconized as a Redis type discoverer
2 participants