Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export ESM Runner from index.mjs instead of cjs runner #1280

Closed
wants to merge 1 commit into from

Conversation

prasadmadanayake
Copy link

馃摑 Description

cjs runner is exported from index.mjs instead of esm runner

馃幆 Relevant issues

馃拵 Type of change

  • Bug fix (non-breaking change which fixes an issue)

馃摐 Example code

import {Runner} from 'moleculer'

//can use runner with native esm
const runner = new Runner();
runner.start(["--env","--hot","--repl","--config","service/moleculer.config.ts","service/**.service.ts"])

馃殾 How Has This Been Tested?

Created a sample service schema and from the main mjs file created a new runner and tested manually.

馃弫 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@PetrChalov
Copy link

PetrChalov commented Apr 19, 2024

@prasadmadanayake please see this, this and this

@icebob
Copy link
Member

icebob commented Apr 21, 2024

In 0.15 I will drop the esm generator script and it will be solved.

@icebob icebob closed this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants