Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move external lib deps to peer deps #37

Merged
merged 6 commits into from
Jun 4, 2017
Merged

Move external lib deps to peer deps #37

merged 6 commits into from
Jun 4, 2017

Conversation

icebob
Copy link
Member

@icebob icebob commented Jun 4, 2017

No description provided.

@icebob icebob merged commit 6185364 into master Jun 4, 2017
@icebob icebob deleted the peer-deps branch June 4, 2017 17:09
@coveralls
Copy link

coveralls commented Jun 4, 2017

Coverage Status

Coverage increased (+0.0004%) to 99.77% when pulling 673d635 on peer-deps into a4f2ae7 on master.

@benchmark-bot
Copy link

🏁 Benchmark results

📝 Moleculer common benchmarks

⚡ Suite: Local call

Test Master PR Diff %
broker.call (normal) 568,654 633,359 +64,705 Performance: +11%
broker.call (with params) 634,679 624,058 -10,621 Performance: -2%

⚡ Suite: Call with middlewares

Test Master PR Diff %
No middlewares 640,307 582,370 -57,937 Performance: -9%
5 middlewares 569,906 641,173 +71,267 Performance: +13%

⚡ Suite: Call with statistics & metrics

Test Master PR Diff %
No statistics 586,271 635,868 +49,597 Performance: +8%
With metrics 84,541 74,658 -9,883 Performance: -12%
With statistics 132,680 154,094 +21,414 Performance: +16%
With metrics & statistics 59,993 62,871 +2,879 Performance: +5%

⚡ Suite: Remote call with FakeTransporter

Test Master PR Diff %
Remote call echo.reply 14,560 14,587 +27 Performance: +0%
Master detailed results
{
  "name": "Moleculer common benchmarks",
  "suites": [
    {
      "name": "Local call",
      "tests": [
        {
          "name": "broker.call (normal)",
          "reference": true,
          "stat": {
            "duration": 4.999525924,
            "cycle": 0,
            "count": 2843000,
            "avg": 0.0000017585388406612734,
            "rps": 568653.9170348744,
            "percent": 0
          }
        },
        {
          "name": "broker.call (with params)",
          "fastest": true,
          "stat": {
            "duration": 5.000952803,
            "cycle": 0,
            "count": 3174000,
            "avg": 0.0000015755994968494013,
            "rps": 634679.0551784378,
            "percent": 11.610776988548238
          }
        }
      ]
    },
    {
      "name": "Call with middlewares",
      "tests": [
        {
          "name": "No middlewares",
          "fastest": true,
          "reference": true,
          "stat": {
            "duration": 5.000726538,
            "cycle": 0,
            "count": 3202000,
            "avg": 0.0000015617509487820113,
            "rps": 640306.9585325923,
            "percent": 0
          }
        },
        {
          "name": "5 middlewares",
          "stat": {
            "duration": 5.000820349,
            "cycle": 0,
            "count": 2850000,
            "avg": 0.0000017546738066666666,
            "rps": 569906.4955552556,
            "percent": -10.99479898495484
          }
        }
      ]
    },
    {
      "name": "Call with statistics & metrics",
      "tests": [
        {
          "name": "No statistics",
          "fastest": true,
          "reference": true,
          "stat": {
            "duration": 4.999391836,
            "cycle": 0,
            "count": 2931000,
            "avg": 0.0000017056949286932787,
            "rps": 586271.3098209732,
            "percent": 0
          }
        },
        {
          "name": "With metrics",
          "stat": {
            "duration": 5.003505661,
            "cycle": 0,
            "count": 423000,
            "avg": 0.000011828618583924351,
            "rps": 84540.72577494782,
            "percent": -85.57993127776224
          }
        },
        {
          "name": "With statistics",
          "stat": {
            "duration": 5.004527244,
            "cycle": 0,
            "count": 664000,
            "avg": 0.0000075369386204819276,
            "rps": 132679.86517529286,
            "percent": -77.3688626830795
          }
        },
        {
          "name": "With metrics & statistics",
          "stat": {
            "duration": 5.000616741,
            "cycle": 0,
            "count": 300000,
            "avg": 0.00001666872247,
            "rps": 59992.600020774116,
            "percent": -89.76709263854413
          }
        }
      ]
    },
    {
      "name": "Remote call with FakeTransporter",
      "tests": [
        {
          "name": "Remote call echo.reply",
          "fastest": true,
          "stat": {
            "duration": 5.151145819,
            "cycle": 0,
            "count": 75000,
            "avg": 0.00006868194425333334,
            "rps": 14559.867383944465,
            "percent": 0
          }
        }
      ]
    }
  ],
  "timestamp": 1496596137893,
  "generated": "Sun Jun 04 2017 17:08:57 GMT+0000 (UTC)",
  "elapsedMs": 46984
}
  
PR detailed results
{
  "name": "Moleculer common benchmarks",
  "suites": [
    {
      "name": "Local call",
      "tests": [
        {
          "name": "broker.call (normal)",
          "fastest": true,
          "reference": true,
          "stat": {
            "duration": 5.000325641,
            "cycle": 0,
            "count": 3167000,
            "avg": 0.000001578884004104831,
            "rps": 633358.7504846267,
            "percent": 0
          }
        },
        {
          "name": "broker.call (with params)",
          "stat": {
            "duration": 4.9995313679999995,
            "cycle": 0,
            "count": 3120000,
            "avg": 0.0000016024139,
            "rps": 624058.490755728,
            "percent": -1.46840313199786
          }
        }
      ]
    },
    {
      "name": "Call with middlewares",
      "tests": [
        {
          "name": "No middlewares",
          "reference": true,
          "stat": {
            "duration": 5.000260868,
            "cycle": 0,
            "count": 2912000,
            "avg": 0.0000017171225508241757,
            "rps": 582369.6156806194,
            "percent": 0
          }
        },
        {
          "name": "5 middlewares",
          "fastest": true,
          "stat": {
            "duration": 5.000207269,
            "cycle": 0,
            "count": 3206000,
            "avg": 0.0000015596404457267622,
            "rps": 641173.4209252436,
            "percent": 10.097334005981722
          }
        }
      ]
    },
    {
      "name": "Call with statistics & metrics",
      "tests": [
        {
          "name": "No statistics",
          "fastest": true,
          "reference": true,
          "stat": {
            "duration": 4.999463318,
            "cycle": 0,
            "count": 3179000,
            "avg": 0.0000015726528210128972,
            "rps": 635868.2518090234,
            "percent": 0
          }
        },
        {
          "name": "With metrics",
          "stat": {
            "duration": 5.009525692,
            "cycle": 0,
            "count": 374000,
            "avg": 0.000013394453721925134,
            "rps": 74657.76662195027,
            "percent": -88.25892527114674
          }
        },
        {
          "name": "With statistics",
          "stat": {
            "duration": 5.003433373,
            "cycle": 0,
            "count": 771000,
            "avg": 0.000006489537448767834,
            "rps": 154094.18743548042,
            "percent": -75.76633414279016
          }
        },
        {
          "name": "With metrics & statistics",
          "stat": {
            "duration": 5.232898015,
            "cycle": 0,
            "count": 329000,
            "avg": 0.00001590546509118541,
            "rps": 62871.471803373184,
            "percent": -90.11250025071924
          }
        }
      ]
    },
    {
      "name": "Remote call with FakeTransporter",
      "tests": [
        {
          "name": "Remote call echo.reply",
          "fastest": true,
          "stat": {
            "duration": 5.073128753,
            "cycle": 0,
            "count": 74000,
            "avg": 0.00006855579395945945,
            "rps": 14586.659161023663,
            "percent": 0
          }
        }
      ]
    }
  ],
  "timestamp": 1496596234660,
  "generated": "Sun Jun 04 2017 17:10:34 GMT+0000 (UTC)",
  "elapsedMs": 47134
}
  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants