321 packet logs

[faeron]

📝 Description

🎯 Relevant issues

#321

💎 Type of change

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

🚦 How Has This Been Tested?

• I started moleculer with npm dev script and defined transit.packetLogFilter for various packet types (heartbeat, discover, info) to verify that log messages do not appear.
• Unit tests

🏁 Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have commented my code, particularly in hard-to-understand areas

[coveralls]

Pull Request Test Coverage Report for Build 1481

• 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.007%) to 92.003%

---

Totals
Change from base Build 1480:	0.007%
Covered Lines:	4632
Relevant Lines:	4813

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 1536

• 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
• 9 unchanged lines in 2 files lost coverage.
• Overall coverage increased (+0.05%) to 91.919%

---

Files with Coverage Reduction	New Missed Lines	%
src/transporters/tcp/tcp-reader.js	1	96.61%
src/service-broker.js	8	92.26%

Totals
Change from base Build 1528:	0.05%
Covered Lines:	4657
Relevant Lines:	4842

---

💛 - Coveralls

[icebob]

Please don't duplicate default values. Use ServiceBroker.defaultOptions.transit instead.

[icebob]

@faeron Could you fix it?
I made benchmarks and there is no performance reduction.

[faeron]

Yup, I will fix it asap.

[faeron]

When trying to use ServiceBroker.defaultOptions.transitsome more tests are failing. It seems that there could be an issue with circular dependencies (Transit now requires ServiceBroker, which itself requires Transit). Any idea on how to resolve that?

[icebob]

Ohh, I see. In this case, drop the defaultOptions in the transit because it gets default options from broker where packetLogFilter is set to [] by default.
In brief, just use this option, no need to merge it with default values in contructor.

Thanks!

[faeron]

Should ready to get merged.

[icebob]

Great, thank you!