Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(handle uv_os_get_passwd error) #396

Merged
merged 2 commits into from
Oct 21, 2018
Merged

fix(handle uv_os_get_passwd error) #396

merged 2 commits into from
Oct 21, 2018

Conversation

katsanva
Copy link
Contributor

📝 Description

When running an application in Openshift Origin (kubernetes, docker) each call to $node.health causes something like

[2018-10-20T20:28:38.445Z] ERROR service-33-2g5bm-7/HEALTH:    Request error! Error : ENOENT: no such file or directory, uv_os_get_passwd 
 Error: ENOENT: no such file or directory, uv_os_get_passwd
    at getOsInfo (/app/node_modules/moleculer/src/health.js:53:12)

Fix is pretty the same as for tilelive-postgis

🎯 Relevant issues

stepankuzmin/tilelive-postgis#10

💎 Type of change

  • Bug fix (non-breaking change which fixes an issue)

🚦 How Has This Been Tested?

  • manually on open shift

🏁 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@katsanva
fix(handle uv_os_get_passwd error)
064e5fd 
See stepankuzmin/tilelive-postgis#10 

When running an application in Openshift Origin (kubernetes, docker) each call to `$node.health` causes something like
```
[2018-10-20T20:28:38.445Z] ERROR service-33-2g5bm-7/HEALTH:    Request error! Error : ENOENT: no such file or directory, uv_os_get_passwd 
 Error: ENOENT: no such file or directory, uv_os_get_passwd
    at getOsInfo (/app/node_modules/moleculer/src/health.js:53:12)
```

Fix is pretty the same as for `tilelive-postgis`
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1503

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 91.989%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/health.js 3 4 75.0%
Totals Coverage Status
Change from base Build 1501: -0.009%
Covered Lines: 4634
Relevant Lines: 4816
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 20, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1504

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 91.989%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/health.js 3 4 75.0%
Totals Coverage Status
Change from base Build 1501: -0.009%
Covered Lines: 4634
Relevant Lines: 4816
💛 - Coveralls

icebob
icebob approved these changes Oct 21, 2018
View reviewed changes
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@icebob icebob merged commit 93b56f0 into moleculerjs:master Oct 21, 2018
@tech-mint
Copy link

@icebob when do you want to release this?
its blocking us in the environment

thanks for your great project

@icebob
Copy link
Member

icebob commented Nov 1, 2018

I'm waiting for some pending PRs. Maybe at the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@katsanva @coveralls @tech-mint @icebob