Service modifications support for ES6 classes

[akazakou]

📝 Description

In some cases architectual solutions can split service and service runner logic. In that case, if you need provide to service some settings or update schema parameters, you can use schemaMods.

It working for GenericObject definition, but not working for ES6 classes. I added providing schemaMods parameters to ES6 classes.

🎯 Relevant issues

#483 Service modifications support for ES6 classes

💎 Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

📜 Example code

class ES6Service extends Service {
	constructor(broker, schemaMods) {
		super(broker);

		this.name = "es6-with-schema-mods";
		this.version = 2;
		this.settings = {};
		this.actions = {
			send: () => Prmise.resolve()
		};

		if (schemaMods && schemaMods.settings && schemaMods.settings.connectionString) {
			this.settings.connectionString = schemaMods.settings.connectionString;
		}

		// this should prevent override this.actions in parseServiceSchema method
		this.parseServiceSchema(Object.assign({}, this));
	}
}

let broker = new ServiceBroker({ logger: false });
broker.createService(ES6Service, { settings: { connectionString: "mongodb://localhost:27017/test" } });

🚦 How Has This Been Tested?

I've added 2 additional unit tests to check schema creating proccess for ES6 classes

• should create service from ES6 instance without schema mods
• should create service from ES6 instance with schema mods

🏁 Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have commented my code, particularly in hard-to-understand areas

[coveralls]

Pull Request Test Coverage Report for Build 1817

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 91.959%

---

Totals
Change from base Build 1798:	0.01%
Covered Lines:	4840
Relevant Lines:	5027

---

💛 - Coveralls

[icebob]

Good job!

[icebob]

Thanks!