Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS: service lifecycles can be arrays #521

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

shawnmcknight
Copy link
Member

馃摑 Description

This PR adjusts the typescript definitions for ServiceSchema to allow the lifecycle events to be typed as arrays.

Note: As there are very few tsd tests in the repo, I am unsure what the expectations are for those types of tests. I did my best to try to create what made sense to me as a test of this change, but will adjust if necessary.

馃幆 Relevant issues

Resolves #520

馃拵 Type of change

  • Bug fix (non-breaking change which fixes an issue)

馃殾 How Has This Been Tested?

Typescript unit tests created to test both single and array specifications.

馃弫 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1822

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 91.959%

Totals Coverage Status
Change from base Build 1821: 0.01%
Covered Lines: 4840
Relevant Lines: 5027

馃挍 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Apr 14, 2019

Pull Request Test Coverage Report for Build 1822

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 91.959%

Totals Coverage Status
Change from base Build 1821: 0.01%
Covered Lines: 4840
Relevant Lines: 5027

馃挍 - Coveralls

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@icebob icebob merged commit 5bc3a44 into moleculerjs:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServiceSchema lifecycle methods TS definitions
3 participants