Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摑 Fixes incorrect proto 3 definition
The Protobuf file is listed as using proto3, but the syntax is incorrect. It seems that protobufjs doesn't care, but protoc does. We are working on implementing the protobuf serializer for moleculer-ruby which requires protoc, and we want full parity between the packets. To do this we are actually curling the proto package from moleculerjs and using that, but the definition file is syntactically incorrect for proto3.
My real suggestion would be to create a new protocol repo, that includes the protocol document itself and the packet definition files for serializers like protobuf.
This should not be a breaking change, as it simply removes the required and optional flags (not supported in proto3).