Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add call middleware type #604

Merged
merged 1 commit into from Oct 17, 2019

Conversation

shawnmcknight
Copy link
Member

馃摑 Description

There is no type signature for middleware definitions wrapping the call action. This PR adds a type signature for this.

馃拵 Type of change

  • Bug fix (non-breaking change which fixes an issue)

馃殾 How Has This Been Tested?

Updated local environment with types. Created a middleware wrapping call using this type definition.

馃弫 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@coveralls
Copy link

coveralls commented Oct 17, 2019

Pull Request Test Coverage Report for Build 2121

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 93.674%

Totals Coverage Status
Change from base Build 2093: 0.02%
Covered Lines: 3884
Relevant Lines: 4004

馃挍 - Coveralls

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@icebob icebob merged commit 18f57b0 into moleculerjs:master Oct 17, 2019
@shawnmcknight
Copy link
Member Author

@icebob While testing out the types for another PR, I noticed that this change did not migrate from master to next. I'm not sure what the cycle is, or even if there is one, to port things from master to next. Let me know if there's anything I need to do to get this migrated to next or if that will just happen on its own at a later date.

@icebob
Copy link
Member

icebob commented Nov 30, 2019

@shawnmcknight you don't need it. Occasionally, I update changes from master to next.

It seems I've forgotten it before beta 6...

@shawnmcknight shawnmcknight deleted the fix-call-middleware-type branch April 10, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants