New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #630 + Backport fix #620 #633

Merged

AndreMaz merged 3 commits into moleculerjs:master from AndreMaz:master

Dec 17, 2019

Member

AndreMaz commented Dec 17, 2019

📝 Description

Closes #630 and fixes #620

🎯 Relevant issues

💎 Type of change

Bug fix (non-breaking change which fixes an issue)

🏁 Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
I have commented my code, particularly in hard-to-understand areas

AndreMaz added 3 commits

December 17, 2019 10:54


          Backport fix moleculerjs#620

411067c


          Fix moleculerjs#630


          Remove old nats test

0fe0ae4

coveralls commented Dec 17, 2019 •

edited

Pull Request Test Coverage Report for Build 2168

6 of 6 (100.0%) changed or added relevant lines in 3 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 93.625%

Files with Coverage Reduction	New Missed Lines	%
src/transporters/fake.js	2	88.89%

Totals
Change from base Build 2163:	-0.04%
Covered Lines:	11646
Relevant Lines:	12012

💛 - Coveralls

icebob approved these changes

View reviewed changes

Member

icebob left a comment

Awesome, please merge it

AndreMaz merged commit aa9afcf into moleculerjs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment