Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/amqp defaults cleanup #650

Merged
merged 1 commit into from Jan 7, 2020
Merged

Feature/amqp defaults cleanup #650

merged 1 commit into from Jan 7, 2020

Conversation

oliversalzburg
Copy link
Contributor

@oliversalzburg oliversalzburg commented Jan 7, 2020 •
edited

馃摑 Description

Leaving the cleanup process disabled will eventually create a lot of unused queues that can be hard to clean up and they are unlikely to every serve any purpose again.

Enabling this feature by default will ensure a good onboarding experience for new implemntors and should result in a smoother experience all over.

馃幆 Relevant issues

馃拵 Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

馃殾 How Has This Been Tested?

Nothing in particular, other than having it manually configured before.

馃弫 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@oliversalzburg oliversalzburg changed the base branch from master to next January 7, 2020 11:02
@oliversalzburg
Clean up AMQP queues by default
dc61c33 
Leaving the cleanup process disabled will eventually create a lot of unused queues that can be hard to clean up and they are unlikely to every serve any purpose again.

Enabling this feature by default will ensure a good onboarding experience for new implemntors and should result in a smoother experience all over.

Fixes #635
@coveralls
Copy link

coveralls commented Jan 7, 2020 •
edited

Pull Request Test Coverage Report for Build 2185

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 94.303%
Totals Coverage Status
Change from base Build 2183: 0.02%
Covered Lines: 13236
Relevant Lines: 13568
馃挍 - Coveralls

Nathan-Schwartz
Nathan-Schwartz reviewed Jan 7, 2020
View reviewed changes
Copy link
Member

@Nathan-Schwartz Nathan-Schwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the PR!

icebob
icebob approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@icebob icebob merged commit 40968ca into moleculerjs:next Jan 7, 2020
@oliversalzburg oliversalzburg deleted the feature/amqp-defaults-cleanup branch January 8, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nathan-Schwartz Nathan-Schwartz Nathan-Schwartz left review comments

@icebob icebob icebob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oliversalzburg @coveralls @icebob @Nathan-Schwartz