Issue #849. Catch decryption failure #850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If decryption fails, catch the error and silently continue.
This prevents a misconfigured node from crashing nodes using Middlewares.Transport.Encryption
馃摑 Description
A misconfigured node should not crash other nodes.
I wrapped the decrypt code in a try/catch block. This will log the following error on the sender's side
[2020-12-28T22:09:47.008Z] WARN plaintext/TRANSPORTER: Invalid incoming GOSSIP_REQ packet
馃幆 Relevant issues
#849
馃拵 Type of change
馃摐 Example code
馃殾 How Has This Been Tested?
Tested against the breaking code in case 849
馃弫 Checklist: