Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding typing for settled in CallingOptions #957

Merged
merged 4 commits into from Jul 5, 2021

Conversation

dprslt
Copy link
Contributor

@dprslt dprslt commented Jul 2, 2021

馃摑 Description

Following our exchange on discord, here is a small fix to add typing for the settled params in mcall.

馃拵 Type of change

Updating Types

馃殾 How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Edit index file
  • Compile

馃弫 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

index.d.ts Show resolved Hide resolved
@intech intech requested a review from icebob July 4, 2021 09:27
@dprslt
Copy link
Contributor Author

dprslt commented Jul 4, 2021

Sorry for the typos... I'm just dumb sometimes..

@intech
Copy link
Member

intech commented Jul 4, 2021

Sorry for the typos... I'm just dumb sometimes..

All ok! I allowed myself to make the changes myself to speed up the merge. It remains to wait for the confirmation of the review.

@icebob icebob requested a review from shawnmcknight July 4, 2021 17:28
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @shawnmcknight please review you too plz.

@shawnmcknight
Copy link
Member

LGTM!

@icebob icebob merged commit cfd321c into moleculerjs:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants