Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import/no-unresolved eslint error being raised on Wouter 3.0.x #423

Closed
mjfwebb opened this issue Mar 4, 2024 · 3 comments · Fixed by #424
Closed

import/no-unresolved eslint error being raised on Wouter 3.0.x #423

mjfwebb opened this issue Mar 4, 2024 · 3 comments · Fixed by #424
Labels
bug Something isn't working

Comments

@mjfwebb
Copy link
Contributor

mjfwebb commented Mar 4, 2024

Hello! Thanks for Wouter, I love using it.

I was migrating to Wouter 3 and noticed I had a relatively minor error being reported from an eslint rule import/no-unresolved:

Unable to resolve path to module 'wouter'.

This seems to be related to this issue: import-js/eslint-plugin-import#2132

From their discussions, it seems the problem is that the Wouter's package.json does not have a main entry. I confirmed that adding "main": "esm/index.js", to the Wouter package.json resolved this error.

Is this something you would be willing to address? If so, I'm happy to make a PR.

Otherwise, I can simply ignore the error, but it might be something that others come across as well.

@molefrog
Copy link
Owner

molefrog commented Mar 4, 2024

Hi! Yep, this makes sense. Feel free to open a PR. Make sure the modify wouter-preact as well.

@molefrog molefrog added the bug Something isn't working label Mar 4, 2024
mjfwebb added a commit to mjfwebb/wouter that referenced this issue Mar 4, 2024
@molefrog
Copy link
Owner

molefrog commented Mar 6, 2024

Hey @mjfwebb let me know if it fixed the issue.

@mjfwebb
Copy link
Contributor Author

mjfwebb commented Mar 6, 2024

Yep, @molefrog it's fixed in 3.0.2! Thanks!

@mjfwebb mjfwebb closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants