Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add navigation support to history #25

Merged
merged 5 commits into from
May 13, 2019
Merged

Conversation

molefrog
Copy link
Owner

  • Makes sure the history.back() / go() ... methods are supported.
  • Replaces replaceHistory with pushHistory.
  • Rewrites a few specs

@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #25 into master will increase coverage by 0.78%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   95.27%   96.06%   +0.78%     
==========================================
  Files           5        5              
  Lines         127      127              
  Branches       26       26              
==========================================
+ Hits          121      122       +1     
+ Misses          5        4       -1     
  Partials        1        1
Impacted Files Coverage Δ
history.js 100% <100%> (ø) ⬆️
index.js 94.54% <100%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410a79d...65ad697. Read the comment docs.

@molefrog molefrog merged commit 3e43ff0 into master May 13, 2019
@molefrog molefrog deleted the fix/location-history branch May 13, 2019 16:11
@molefrog molefrog mentioned this pull request May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants