Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for wouter-preact #272

Merged
merged 3 commits into from Dec 14, 2022
Merged

Fixes for wouter-preact #272

merged 3 commits into from Dec 14, 2022

Conversation

fgnass
Copy link
Contributor

@fgnass fgnass commented Nov 28, 2022

This PR is a follow-up to #249 to fix wouter-preact in native ESM environments. It does ...

  1. Add module specifiers from the exports map to typesVersions in wouter-preact, too.
  2. Set the version to "*" for these exports, so it works in TS < 4.1, too.
  3. Add missing .js extension, so the import can be resolved in native ESM envs.

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (dbbad7c) compared to base (5533ed0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #272   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          266       266           
  Branches        53        53           
=========================================
  Hits           266       266           
Impacted Files Coverage Δ
static-location.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@molefrog
Copy link
Owner

molefrog commented Dec 9, 2022

That's awesome! Have you already tested these changes in a ESM env?

Copy link
Owner

@molefrog molefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants