v3: memory location #358
Merged
v3: memory location #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #358 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 11 11
Branches 3 3
=========================================
Hits 11 11 ☔ View full report in Codecov by Sentry. |
molefrog
reviewed
Oct 10, 2023
molefrog
requested changes
Oct 10, 2023
Co-authored-by: Alexey Taktarov <molefrog@gmail.com>
molefrog
reviewed
Oct 10, 2023
| const useMemoryLocation = ({ base } = {}) => { | ||
| const location = useSyncExternalStore(subscribe, () => currentPath); | ||
|
|
||
| return [relativePath(base, location), navigate]; |
There was a problem hiding this comment.
I suppose navigate method should transform the path provided using absolutePath similarly to browser location. How to reproduce:
- Use base path
"/app", initial path"/app/users". The value returned from the hook is"/users". - Navigate to
"/settings", the path is"/settings"(with current setup it will be"~/settings"
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement #355
memory locationhook