update type definition #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molefrog
reviewed
Nov 18, 2019
types/index.d.ts
Outdated
| @@ -62,6 +62,7 @@ export const Switch: FunctionComponent<SwitchProps>; | |||
|
|
|||
| export interface RouterProps { | |||
| hook: LocationHook; | |||
| basepath: string; | |||
There was a problem hiding this comment.
While it's not really critical, but I would suggest using a Path type here (which is just an alias to string, but helps to keep the code more generic I guess). Basically Path represents something that can describe a location.
There was a problem hiding this comment.
good idea!! Thx! i will fix it
molefrog
approved these changes
Nov 18, 2019
|
@cbbfcd thank you very much! You help us a lot |
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 99.45% 99.44% -0.01%
==========================================
Files 7 7
Lines 182 181 -1
Branches 32 32
==========================================
- Hits 181 180 -1
Misses 1 1
Continue to review full report at Codecov.
|
molefrog
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update type definition, because we have
basepathnow!