-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript improvements #84
Conversation
@@ -47,7 +47,7 @@ | |||
"eslint-plugin-sort-destructure-keys": "^1.3.5", | |||
"eslint-plugin-unicorn": "^20.1.0", | |||
"prettier": "^2.0.0", | |||
"typescript": "^3.0.0" | |||
"typescript": "^4.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also update @typescript-eslint/parser
and @typescript-eslint/eslint-plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
"@rushstack/eslint-patch": "^1.0.2", | ||
"@typescript-eslint/eslint-plugin": "^3.6.0", | ||
"@typescript-eslint/parser": "^3.0.0", | ||
"babel-eslint": "^10.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we no longer need this parser.
module.exports = Object.assign( | ||
{}, | ||
{ | ||
extends: ['./javascript', './typescript', './cypress', './jest', './react'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Load all rule definitions to see if they are valid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes #69
Fixes #70
Fixes #78
Fixes #83
Fixes #85
Pre-release: